Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update rdf-canonize, node versions, and more. #548

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Update rdf-canonize, node versions, and more. #548

wants to merge 4 commits into from

Conversation

davidlehn
Copy link
Member

No description provided.

@davidlehn
Drop support for Node.js < 18.
2117c3b
@davidlehn
Update to rdf-canonize@4.
20fa0cf 
- **BREAKING**: See the `rdf-canonize` 4.0.0 changelog for **important**
  changes and upgrade notes.
- Update to handle different RDF/JS dataset `BlankNode` format.
- Enable pass through of numerous possible `rdf-canonize` options in a
  `canonize()` `canonizeOptions` parameter.
- Update to use `rdf-canonize` options.
- The `URDNA2015` default algorithm has been changed to `RDFC-1.0` from
  `rdf-canon`.
- Complexity control defaults `maxWorkFactor` or `maxDeepIterations` may
  need to be adjusted to process graphs with certain blank node
  constructs.
- A `signal` option is available to use an `AbortSignal` to limit
  resource usage.
- The internal digest algorithm can be changed.
@davidlehn
Remove support for application/nquads alias.
2409091
@davidlehn
Update dependencies.
7357959
@codecov-commenter
Copy link

Codecov Report

Merging #548 (7357959) into main (5367858) will increase coverage by 0.10%.
The diff coverage is 100.00%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #548      +/-   ##
==========================================
+ Coverage   93.63%   93.74%   +0.10%     
==========================================
  Files          24       24              
  Lines        2986     2989       +3     
==========================================
+ Hits         2796     2802       +6     
+ Misses        190      187       -3
Files Coverage Δ
lib/fromRdf.js 98.58% <100.00%> (+0.07%) ⬆️
lib/jsonld.js 85.26% <100.00%> (+0.98%) ⬆️
lib/toRdf.js 99.21% <100.00%> (-0.03%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5367858...7357959. Read the comment docs.

@dlongley dlongley mentioned this pull request Feb 26, 2024
Closed
@davidlehn davidlehn mentioned this pull request May 31, 2024
Open
@gabboman
Copy link

This pr fixes some security issues. Would be good to update the http library too to the 4.11 version.
the http library on the 3.xx branch has a dependency on udincy or something like that wich leaks memory.

Is there any way of helping with this or testing the beta branch with the fixes?

@gabboman
Copy link

update: I tried myself installing just the newer version of the httpclient on my project and that caused an infinite loop in some cases. This may need some investigation and just updating dependencies may not just cut it

@RinkeHoekstra
Copy link

Would be great if this change could be merged!

@gabboman
Copy link

ignore my previous comment the library is safe was one of my changes that had an whoopsie

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dlongley dlongley dlongley approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@davidlehn @codecov-commenter @gabboman @RinkeHoekstra @dlongley