Update direction support. #534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the GitHub App Integration for your organization. Read more. @@ Coverage Diff @@
## main #534 +/- ##
==========================================
- Coverage 93.66% 93.63% -0.03%
==========================================
Files 24 24
Lines 2968 2986 +18
==========================================
+ Hits 2780 2796 +16
- Misses 188 190 +2
|
- Emit `toRdf` warning if `@direction` is used and `rdfDirection` is not set. - Add safe mode support for `@direction`. Using `@direction` without `rdfDirection` set will cause a safe mode failure. - Add tests.
davidlehn
force-pushed
the
update-direction-support
branch
from
0ca4360
to
3754a2c
Compare
dlongley
approved these changes
Sep 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
toRdfwarning if@directionis used andrdfDirectionis not set.@direction. Using@directionwithoutrdfDirectionset will cause a safe mode failure.