Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test on Node.js 16.x and 18.x. #976

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Test on Node.js 16.x and 18.x. #976

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
48f01e6
Test on Node.js 16.x and 18.x.
davidlehn Apr 19, 2022
dd1c202
Test on Node.js 20.x and 22.x.
davidlehn May 22, 2024
0be960f
Fix Node.js versions used during testing.
davidlehn May 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 21 additions & 14 deletions .github/workflows/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,27 +8,33 @@ jobs:
timeout-minutes: 10
strategy:
matrix:
node-version: [6.x, 8.x, 10.x, 12.x, 14.x]
node-version: [6.x, 8.x, 10.x, 12.x, 14.x, 16.x, 18.x, 20.x, 22.x]
steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v4
# FIXME: Install/build with 16.x until webpack is updated
- name: Use Node.js 16.x
uses: actions/setup-node@v4
with:
node-version: 16.x
- run: npm install
# FIXME: Run tests with target version until webpack is updated
- name: Use Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v1
uses: actions/setup-node@v4
with:
node-version: ${{ matrix.node-version }}
- run: npm install
- name: Run test with Node.js ${{ matrix.node-version }}
run: npm run test-node
test-karma:
runs-on: ubuntu-latest
timeout-minutes: 10
strategy:
matrix:
node-version: [14.x]
node-version: [16.x]
bundler: [webpack, browserify]
steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v4
- name: Use Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v1
uses: actions/setup-node@v4
with:
node-version: ${{ matrix.node-version }}
- run: npm install
Expand All @@ -41,11 +47,11 @@ jobs:
# timeout-minutes: 10
# strategy:
# matrix:
# node-version: [14.x]
# node-version: [16.x]
# steps:
# - uses: actions/checkout@v2
# - uses: actions/checkout@v4
# - name: Use Node.js ${{ matrix.node-version }}
# uses: actions/setup-node@v1
# uses: actions/setup-node@v4
# with:
# node-version: ${{ matrix.node-version }}
# - run: npm install
Expand All @@ -56,18 +62,19 @@ jobs:
timeout-minutes: 10
strategy:
matrix:
node-version: [14.x]
node-version: [16.x]
steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v4
- name: Use Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v1
uses: actions/setup-node@v4
with:
node-version: ${{ matrix.node-version }}
- run: npm install
- name: Generate coverage report
run: npm run coverage-ci
- name: Upload coverage to Codecov
uses: codecov/codecov-action@v1
uses: codecov/codecov-action@v4
with:
file: ./coverage/lcov.info
fail_ci_if_error: true
token: ${{ secrets.CODECOV_TOKEN }}