Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VSCode's nodejs bump breaks IDE #19721

Open
samuel-williams-da opened this issue Aug 6, 2024 · 1 comment · Fixed by #19723, #19724 or #19722
Open

VSCode's nodejs bump breaks IDE #19721

samuel-williams-da opened this issue Aug 6, 2024 · 1 comment · Fixed by #19723, #19724 or #19722
Assignees
@samuel-williams-da
Labels
broken Product is broken and must be fixed

Comments

@samuel-williams-da
Copy link
Contributor

samuel-williams-da commented Aug 6, 2024 •
edited
Loading

As of https://code.visualstudio.com/updates/v1_92, VSCode now uses a version of nodejs that doesn't allow spawning processes via their .cmd file, which is what we do in windows.
The fix should simply be to add shell: true to the spawn, but I'm verifying this.
This will need fixing across main, main-2.x, release/2.9.x.

A temporary workaround is to use the previous VSCode release.
@samuel-williams-da samuel-williams-da self-assigned this Aug 6, 2024
@samuel-williams-da samuel-williams-da mentioned this issue Aug 6, 2024
Merged
This was linked to pull requests Aug 6, 2024
Fix VSCode starting daml IDE #19723
Merged
Fix VSCode starting daml IDE #19724
Merged
Fix VSCode starting daml IDE #19722
Merged
@samuel-williams-da samuel-williams-da added the broken Product is broken and must be fixed label Aug 6, 2024
@samuel-williams-da
Copy link
Contributor Author

Also needed on 2.8

@samuel-williams-da samuel-williams-da mentioned this issue Aug 30, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@samuel-williams-da samuel-williams-da

Labels
broken Product is broken and must be fixed
Projects
None yet
Milestone
No milestone
1 participant
@samuel-williams-da