Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check whether safeCPickleDumps(obj): is still needed #189

Open
sbillinge opened this issue Aug 21, 2024 · 3 comments
Open

check whether safeCPickleDumps(obj): is still needed #189

sbillinge opened this issue Aug 21, 2024 · 3 comments
Milestone

Comments

@sbillinge
Copy link
Contributor

This may be another py2 compatibility function. Check where it is used and whether it can be removed.

Write tests to make sure the behavior is still handled.

@sbillinge sbillinge added this to the v3.2.0 milestone Aug 21, 2024
@Tieqiong
Copy link
Contributor

@sbillinge this method ensures that an object is serialized even if it contains problematic floating-point values by falling back to a simpler serialization protocol if the default one fails.

In Python 3, the pickle module uses more recent protocols, and the SystemError related to frexp() is less likely to occur. So I think the fallback to ASCII protocol (protocol 0) is not necessary any more.

Yes test would be the right thing to do

@bobleesj
Copy link
Contributor

@Tieqiong will take care of it for v3.1.0

@bobleesj
Copy link
Contributor

bobleesj commented Oct 2, 2024

@Tieqiong could you please share an update on this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants