Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why not pull space group from file? #12

Open
CJ-Wright opened this issue Oct 20, 2017 · 1 comment
Open

Why not pull space group from file? #12

CJ-Wright opened this issue Oct 20, 2017 · 1 comment

Comments

@CJ-Wright
Copy link
Member

In this example why is the space group not pulled from the cif file?

@pavoljuhas
Copy link
Member

The example mimics what happens in PDFgui. diffpy.Structure has no direct facility for space-group based crystal representation, therefore loadStructure expands the CIF to P1. The user then works with such expanded structure and can constrain it with either the CIF space group or with a lower-symmetry supergroup to allow more distortions in the model.

The second reason is that diffpy.Structure has a bit clunky API for getting the CIF space group. A better option for refining CIF structure with CIF space group is to use pyobjcryst.loadCrystal instead of loadStructure. pyobjcryst has SG-based representation so the space group would be then applied in the refinement by default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants