Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cleanthat to spotless config #1578

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

blacelle
Copy link
Contributor

This refers to #1532, considering var usage enforcement.

It does not implement unless the line has a comment part of the spec. I wonder how much this is a strict requirement. (Also, does it include comment before the variable declaration ? What if the variable declaration stands on multiple rows?)

This fails with spotless-gradle 6.15.0 ; the fix is pending for next spotless-gradle release.

@blacelle blacelle marked this pull request as ready for review March 7, 2023 06:49
@blacelle
Copy link
Contributor Author

@nedtwigg This has been resynced with main. Ready-for-merging

@nedtwigg
Copy link
Member

nedtwigg commented Apr 5, 2023

I am eager to add cleanthat to our code style. But change in our code style will cause merge conflicts, so this PR is also blocked on

@nedtwigg nedtwigg added the pr-archive PRs which are still valid but have gotten stuck for some reason label Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-archive PRs which are still valid but have gotten stuck for some reason
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants