Remove dynamic_cast from hardness collection code paths #8423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tautschnig
requested review from
martin-cs,
peterschrammel and
kroening
as code owners
tautschnig
force-pushed
the
hardness-no-dynamic_cast
branch
2 times, most recently
from
f588fa1
to
b0db893
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #8423 +/- ##
===========================================
+ Coverage 77.86% 78.19% +0.33%
===========================================
Files 1726 1726
Lines 189890 189085 -805
Branches 18221 18261 +40
===========================================
+ Hits 147849 147858 +9
+ Misses 42041 41227 -814 ☔ View full report in Codecov by Sentry. |
Remove methods that were never used (and one that wasn't even implemented), mark `protected` what doesn't need to be part of the public API, and remove an unnecessary case of a default parameter.
tautschnig
force-pushed
the
hardness-no-dynamic_cast
branch
from
b0db893
to
235683c
Compare
Use a `shared_ptr` to retain co-ownership of the hardness collector in `solver_factoryt::solvert` and adjust the `symex_target_equationt` API to `consume a solver_hardnesst`.
tautschnig
force-pushed
the
hardness-no-dynamic_cast
branch
from
235683c
to
44fd5e8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use a
shared_ptrto retain co-ownership of the hardness collector insolver_factoryt::solvertand adjust thesymex_target_equationtAPI toconsume a solver_hardnesst.