Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contracts (DFCC) regression tests: use CaDiCaL #8414

Merged
merged 1 commit into from
Aug 20, 2024

Conversation

tautschnig
Copy link
Collaborator

Using CaDiCaL as SAT solver (when available) instead of MiniSat reduces test execution time from 337 seconds down to 131 seconds (with only a single test now taking more than 2 seconds, where its 6 seconds are mainly spent in symex).

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

Using CaDiCaL as SAT solver (when available) instead of MiniSat reduces
test execution time from 337 seconds down to 131 seconds (with only a
single test now taking more than 2 seconds, where its 6 seconds are
mainly spent in symex).
Copy link

codecov bot commented Aug 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.94%. Comparing base (0760cd7) to head (4fd1cf8).
Report is 8 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #8414   +/-   ##
========================================
  Coverage    77.94%   77.94%           
========================================
  Files         1726     1726           
  Lines       189624   189624           
  Branches     18257    18258    +1     
========================================
  Hits        147801   147801           
  Misses       41823    41823           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tautschnig tautschnig merged commit a395044 into diffblue:develop Aug 20, 2024
40 checks passed
@tautschnig tautschnig deleted the contracts-dfcc-cadical branch August 20, 2024 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants