Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamic frames: do not add trivial properties #8413

Merged
merged 1 commit into from
Aug 17, 2024

Conversation

tautschnig
Copy link
Collaborator

There is no need to add ASSERT true to the collection of properties.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

There is no need to add `ASSERT true` to the collection of properties.
Copy link

codecov bot commented Aug 13, 2024

Codecov Report

Attention: Patch coverage is 72.72727% with 6 lines in your changes missing coverage. Please review.

Project coverage is 77.95%. Comparing base (0760cd7) to head (2214a76).
Report is 2 commits behind head on develop.

Files Patch % Lines
...ument/contracts/dynamic-frames/dfcc_instrument.cpp 72.72% 6 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #8413   +/-   ##
========================================
  Coverage    77.94%   77.95%           
========================================
  Files         1726     1726           
  Lines       189624   189601   -23     
  Branches     18257    18250    -7     
========================================
- Hits        147801   147796    -5     
+ Misses       41823    41805   -18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tautschnig tautschnig merged commit b87d38a into diffblue:develop Aug 17, 2024
39 of 40 checks passed
@tautschnig tautschnig deleted the dfcc-no-unnecessary-check branch August 17, 2024 07:22
tautschnig added a commit to tautschnig/kani that referenced this pull request Aug 27, 2024
With diffblue/cbmc#8413, CBMC will no longer create property checks for
assigns clauses that are trivially true.
github-merge-queue bot pushed a commit to model-checking/kani that referenced this pull request Aug 27, 2024
With diffblue/cbmc#8413, CBMC will no longer create property checks for
assigns clauses that are trivially true.

We had CBMC-Nightly failing since August 17th given the CBMC change.
This will bring CBMC-Nightly back to a passing state.

By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 and MIT licenses.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants