Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solver factory: set_decision_procedure_time_limit does not require dynamic_cast #8409

Merged

Conversation

tautschnig
Copy link
Collaborator

At each call site we already know whether the decision procedure is a solver_resource_limitst, so we just don't invoke it when it is not.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

…namic_cast

At each call site we already know whether the decision procedure is a
`solver_resource_limitst`, so we just don't invoke it when it is not.
Copy link

codecov bot commented Aug 7, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 78.03%. Comparing base (d635850) to head (27aa454).

Files Patch % Lines
src/goto-checker/solver_factory.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #8409      +/-   ##
===========================================
- Coverage    78.04%   78.03%   -0.01%     
===========================================
  Files         1726     1726              
  Lines       189394   189409      +15     
  Branches     18263    18465     +202     
===========================================
- Hits        147810   147807       -3     
- Misses       41584    41602      +18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kroening kroening merged commit 7db3d8b into diffblue:develop Aug 7, 2024
38 of 40 checks passed
@tautschnig tautschnig deleted the solver-factory-no-dynamic_cast2 branch August 7, 2024 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants