Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dynamic_cast from bv_dimacst #8406

Merged
merged 1 commit into from
Aug 7, 2024

Conversation

tautschnig
Copy link
Collaborator

We can just hold on to the dimacs_cnft typed instance of propt that is used for constructing the object.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

We can just hold on to the dimacs_cnft typed instance of propt that is
used for constructing the object.
Copy link

codecov bot commented Aug 6, 2024

Codecov Report

Attention: Patch coverage is 70.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 78.02%. Comparing base (5ef19c8) to head (30ff419).

Files Patch % Lines
src/solvers/flattening/bv_dimacs.cpp 57.14% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #8406      +/-   ##
===========================================
- Coverage    78.02%   78.02%   -0.01%     
===========================================
  Files         1726     1726              
  Lines       189442   189448       +6     
  Branches     18466    18263     -203     
===========================================
+ Hits        147808   147809       +1     
- Misses       41634    41639       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kroening kroening merged commit f244575 into diffblue:develop Aug 7, 2024
38 of 40 checks passed
@tautschnig tautschnig deleted the dimacs_cnft-no-dynamic_cast branch August 7, 2024 05:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants