Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C++ front-end: support constexpr #8386

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

tautschnig
Copy link
Collaborator

Mark constexpr symbols as macros and use direct replacement (non-function symbols) or in-place evaluation (uses of constexpr function symbols).

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

Mark `constexpr` symbols as macros and use direct replacement
(non-function symbols) or in-place evaluation (uses of `constexpr`
function symbols).
Copy link

codecov bot commented Jul 17, 2024

Codecov Report

Attention: Patch coverage is 79.45205% with 15 lines in your changes missing coverage. Please review.

Project coverage is 77.91%. Comparing base (82bbeb8) to head (514db34).

Files Patch % Lines
src/cpp/cpp_typecheck_expr.cpp 84.21% 6 Missing ⚠️
src/cpp/parse.cpp 50.00% 6 Missing ⚠️
src/cpp/cpp_storage_spec.cpp 50.00% 1 Missing ⚠️
src/cpp/cpp_storage_spec.h 87.50% 1 Missing ⚠️
src/cpp/cpp_typecheck_resolve.cpp 80.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #8386      +/-   ##
===========================================
- Coverage    78.32%   77.91%   -0.41%     
===========================================
  Files         1726     1726              
  Lines       188506   189560    +1054     
  Branches     18249    18255       +6     
===========================================
+ Hits        147646   147704      +58     
- Misses       40860    41856     +996     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants