Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix multiplication and division of complex numbers #8376

Merged
merged 1 commit into from
Jul 12, 2024

Conversation

tautschnig
Copy link
Collaborator

@tautschnig tautschnig commented Jul 11, 2024

Multiplication and division of complex numbers are not just pointwise applications of those operations.

Fixes: #8375

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

Copy link

codecov bot commented Jul 11, 2024

Codecov Report

Attention: Patch coverage is 20.98765% with 64 lines in your changes missing coverage. Please review.

Project coverage is 78.32%. Comparing base (629dbcd) to head (e449479).

Files Patch % Lines
src/solvers/flattening/boolbv_floatbv_op.cpp 0.00% 46 Missing ⚠️
src/goto-programs/remove_complex.cpp 48.57% 18 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #8376      +/-   ##
===========================================
- Coverage    78.35%   78.32%   -0.03%     
===========================================
  Files         1726     1726              
  Lines       188424   188498      +74     
  Branches     18248    18252       +4     
===========================================
+ Hits        147631   147650      +19     
- Misses       40793    40848      +55     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tautschnig tautschnig force-pushed the bugfixes/complex-8375 branch 2 times, most recently from 5d7d5b9 to 8b9fc62 Compare July 12, 2024 09:37
Multiplication and division of complex numbers are not just pointwise
applications of those operations.

Fixes: diffblue#8375
@tautschnig tautschnig merged commit 3dcc1c7 into diffblue:develop Jul 12, 2024
37 of 39 checks passed
@tautschnig tautschnig deleted the bugfixes/complex-8375 branch July 12, 2024 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multiplication of complex number is modelled incorrectly
3 participants