Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

embedd files using hex literals instead of string literals #8332

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

kroening
Copy link
Member

String constants are limited to 64k, which requires splitting the file with the compiler headers.

This switches the embedding to use an array of hex literals, which have no size limit.

There is a prospect to use the #embed preprocessor command in C++26, moves the conversion from file to hex literal array into the compiler's preprocessor.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

String constants are limited to 64k, which requires splitting the file with
the compiler headers.

This switches the embedding to use an array of hex literals, which have no
size limit.

There is a prospect to use the #embed preprocessor command in C++26, moves
the conversion from file to hex literal array into the compiler's
preprocessor.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant