Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C++ front-end fixes #8275

Draft
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

tautschnig
Copy link
Collaborator

Please review commit-by-commit. This gets us somewhat closer to being able to process type_traits.

  • Each commit message has a non-empty body, explaining why the change was made.
  • Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

@tautschnig tautschnig self-assigned this May 7, 2024
Copy link

codecov bot commented May 7, 2024

Codecov Report

Attention: Patch coverage is 75.91837% with 59 lines in your changes missing coverage. Please review.

Project coverage is 77.88%. Comparing base (2523f2c) to head (83b210e).
Report is 2 commits behind head on develop.

Files Patch % Lines
src/cpp/parse.cpp 71.16% 47 Missing ⚠️
src/cpp/cpp_typecheck_expr.cpp 85.41% 7 Missing ⚠️
src/ansi-c/scanner.l 60.00% 2 Missing ⚠️
src/cpp/cpp_storage_spec.cpp 50.00% 1 Missing ⚠️
src/cpp/cpp_storage_spec.h 87.50% 1 Missing ⚠️
src/cpp/cpp_typecheck_resolve.cpp 80.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #8275      +/-   ##
===========================================
- Coverage    78.32%   77.88%   -0.45%     
===========================================
  Files         1726     1726              
  Lines       188506   189767    +1261     
  Branches     18249    18360     +111     
===========================================
+ Hits        147646   147798     +152     
- Misses       40860    41969    +1109     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tautschnig tautschnig force-pushed the bugfixes/cpp-constexpr branch 4 times, most recently from bb79589 to 04bcc91 Compare May 11, 2024 14:13
Mark `constexpr` symbols as macros and use direct replacement
(non-function symbols) or in-place evaluation (uses of `constexpr`
function symbols).
Attach the "ellipsis" information to the declarator and not to the type.
This reverts commit 4c299cc716f9e0bf639411296f1ee5f2c5d96300.
Now follows the grammar described in the C++ standard: Explicit type
conversions are postfix expressions. This required adding rules for C++
cast expressions, which in turn simplifies type checking for we no
longer treat them as function calls with template arguments.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant