You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In this issue it has been noted that lineHeight is limited to the unitless number value type (thus lineHeight = x * fontSize).
While this is not wrong behaviour, the usual CSS line height property also allows for other value types, eg. length.
This key difference should be noted in the docs.
Also, it may be prudent to change the type of lineHeight to number, as strings (commonly used in JSX styling for CSS values containing units) could lead to false confidence in the acceptable values of lineHeight.
The text was updated successfully, but these errors were encountered:
In this issue it has been noted that
lineHeight
is limited to the unitless number value type (thuslineHeight = x * fontSize
).While this is not wrong behaviour, the usual CSS line height property also allows for other value types, eg. length.
This key difference should be noted in the docs.
Also, it may be prudent to change the type of
lineHeight
tonumber
, as strings (commonly used in JSX styling for CSS values containing units) could lead to false confidence in the acceptable values oflineHeight
.The text was updated successfully, but these errors were encountered: