Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(frontend): add exporerUrl to BTC networks [GIX-2795] #2557

Conversation

DenysKarmazynDFINITY
Copy link
Contributor

Motivation

The goal is to extend BTC networks with already defined explorer URLs. It will be used in the BTC transaction detail modal.

@DenysKarmazynDFINITY DenysKarmazynDFINITY requested a review from a team as a code owner September 27, 2024 09:08
@DenysKarmazynDFINITY DenysKarmazynDFINITY changed the title feat(frontend): add exporerUrl to BTC networks feat(frontend): add exporerUrl to BTC networks [GIX-2795] Sep 27, 2024
Copy link
Contributor

@AntonioVentilii-DFINITY AntonioVentilii-DFINITY left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to simplify the code, we have already EthereumAppMetadata: can we "merge" the two types and have something like NetworkAppMetadata? (that should include the original optionality/non-optionality of both)

@DenysKarmazynDFINITY
Copy link
Contributor Author

@AntonioVentilii-DFINITY good idea, it's done. explorerUrl is required in NetworkMetadataApp but I made it optional just for BTC to be compatible with regtest network type (no explorer there).

Copy link
Contributor

@AntonioVentilii-DFINITY AntonioVentilii-DFINITY left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Small observation

src/frontend/src/btc/types/network.ts Outdated Show resolved Hide resolved
@DenysKarmazynDFINITY DenysKarmazynDFINITY merged commit 9996be2 into feat(frontend)/btc-transactions Sep 27, 2024
6 checks passed
@DenysKarmazynDFINITY DenysKarmazynDFINITY deleted the feat(frontend)/btc-network-exporer-url branch September 27, 2024 10:10
DenysKarmazynDFINITY added a commit that referenced this pull request Sep 27, 2024
# Motivation

The goal is to extend BTC networks with already defined explorer URLs.
It will be used in the BTC transaction detail modal.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants