style(frontend): new header title when signed off [GIX-3015] #2556
+5
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AntonioVentilii-DFINITY
changed the title
AntonioVentilii-DFINITY
requested review from
peterpeterparker and
DenysKarmazynDFINITY
src/frontend/src/lib/i18n/en.json
Outdated
| "title_part_1": "A wallet that lives on-chain for", | ||
| "title_part_2": "100% decentralization", | ||
| "title_part_1": "Multi-chain wallet.", | ||
| "title_part_2": "100% onchain", |
There was a problem hiding this comment.
On the screenshot that Andronikos shared in Slack, the second part also has a dot (100% on chain.).
There was a problem hiding this comment.
The foundation wants "onchain" I understand.
See for example this recent PR applied to the portal: dfinity/portal#3530
There was a problem hiding this comment.
Oh true, it should be 100% onchain.. The question about the dot is still pending though.
There was a problem hiding this comment.
On the screenshot that Andronikos shared in Slack, the second part also has a dot (100% on chain.).
Good catch! Corrected
DenysKarmazynDFINITY
approved these changes
Sep 27, 2024
AntonioVentilii-DFINITY
deleted the
style(frontend)/new-header-title-when-signed-off
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
New header title when the user is not signed in.