test(e2e): homepage screenshot tests #2033
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
To get the pipeline correctly running, #2032 should be merged first. Though, the PR code can be already reviewed. |
DenysKarmazynDFINITY
force-pushed
the
test(frontend)/homepage-snapshots
branch
3 times, most recently
from
b5331d2
to
edb6b77
Compare
|
The pipeline is now green, so PR can be fully reviewed. |
DenysKarmazynDFINITY
force-pushed
the
test(frontend)/homepage-snapshots
branch
2 times, most recently
from
8697de6
to
e7fa7e6
Compare
|
@peterpeterparker @AntonioVentilii-DFINITY thanks for the reviews! I applied all your comments, so the code is ready for another go. |
DenysKarmazynDFINITY
force-pushed
the
test(frontend)/homepage-snapshots
branch
from
f5bd7c2
to
4c8c052
Compare
DenysKarmazynDFINITY
force-pushed
the
test(frontend)/homepage-snapshots
branch
from
2e27948
to
58e790f
Compare
DenysKarmazynDFINITY
force-pushed
the
test(frontend)/homepage-snapshots
branch
from
58e790f
to
af49eff
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The goal of this PR is to add basic snapshot tests for homepage (user logged in and logged out states).
Changes
Tests
Please see the committed screenshots.