Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate vite #248

Merged
merged 20 commits into from
Sep 5, 2024
Merged

Migrate vite #248

merged 20 commits into from
Sep 5, 2024

Conversation

chenyan-dfinity
Copy link
Contributor

No description provided.

@rvanasa rvanasa mentioned this pull request Sep 4, 2024
Merged
@rvanasa rvanasa mentioned this pull request Sep 4, 2024
Merged
rvanasa and others added 4 commits September 5, 2024 13:23
@rvanasa
More refactoring for Vite migration (#252)
3254f9a 
* Reintroduce 'global' for dev server

* Refactor to use 'Motoko' promise instead of global variable

* Misc

* Only run 'eval()' in 'loadMoc()' at most once

* Reformat
@chenyan-dfinity
Merge remote-tracking branch 'origin/main' into migrate-vite
9d904ae
@chenyan-dfinity
chunking
25b71d4
@chenyan-dfinity
fix
b99cc76
@chenyan-dfinity chenyan-dfinity marked this pull request as ready for review September 5, 2024 21:09
rvanasa
rvanasa approved these changes Sep 5, 2024
View reviewed changes
Copy link
Contributor

@rvanasa rvanasa left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! It's worth noting that the npm test command currently doesn't work (since we would probably want to set up Vitest), but that seems okay since the original command was runnable but unused.

src/config/actor.tsx Outdated Show resolved Hide resolved
@chenyan-dfinity chenyan-dfinity merged commit 2ccaf64 into main Sep 5, 2024
5 checks passed
@chenyan-dfinity chenyan-dfinity deleted the migrate-vite branch September 5, 2024 22:49
@ggreif ggreif mentioned this pull request Sep 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rvanasa rvanasa rvanasa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chenyan-dfinity @rvanasa @krpeacock