Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor stats #195

Merged
merged 13 commits into from
Sep 12, 2023
Merged

refactor stats #195

merged 13 commits into from
Sep 12, 2023

Conversation

chenyan-dfinity
Copy link
Contributor

@chenyan-dfinity chenyan-dfinity commented Sep 10, 2023

  • LogsByOrigin now only contains canister and wasm level key-value stores. There is no need to have a dedicated origin key-value store.
  • Naming convention:
    • server side adds origin: prefix for origin field. Well-known origin: playground, dfx, spawned.
    • server side tags: wasm:profiling, wasm:asset, mode:install, mode:reinstall, mode:upgrade
    • client side tags: example:{name}, file:new, post:{url}, git:{repo}, tag:{id}, ref:{url}, upload:wasm, wasm:init_args, moc:gc:force, moc:gc:{method}, import:package:{repo}, import:canister:{id}.
  • Add a frontend at play.motoko.org/stats

src/index.js Show resolved Hide resolved
src/index.js Show resolved Hide resolved
src/Stats.tsx Outdated Show resolved Hide resolved
src/components/DeployModal.tsx Show resolved Hide resolved
src/components/DeployModal.tsx Show resolved Hide resolved
src/components/ImportGithub.tsx Show resolved Hide resolved
Copy link
Contributor

@rvanasa rvanasa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@chenyan-dfinity chenyan-dfinity merged commit 4793ef1 into main Sep 12, 2023
4 checks passed
@chenyan-dfinity chenyan-dfinity deleted the fix-stats branch September 12, 2023 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants