refactor(nns): Spin out sum_weighted_voting_power. #2619
Merged
+126
−52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daniel-wong-dfinity-org
force-pushed
the
spin-out-sum_weighted_voting_power-daniel-wong
branch
from
ab5591c
to
7e3e17c
Compare
max-dfinity
approved these changes
Nov 14, 2024
daniel-wong-dfinity-org
force-pushed
the
spin-out-sum_weighted_voting_power-daniel-wong
branch
from
7e3e17c
to
1655dba
Compare
Base automatically changed from
distribute-voting-rewards-based-on-potential-voting-power-daniel-wong
to
master
November 15, 2024 16:16
daniel-wong-dfinity-org
force-pushed
the
spin-out-sum_weighted_voting_power-daniel-wong
branch
from
1655dba
to
3af3713
Compare
daniel-wong-dfinity-org
deleted the
spin-out-sum_weighted_voting_power-daniel-wong
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This used to be part of #2385, but I was asked to not spin out sum_weighted_voting_power from distribute_rewards.