Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(sns): Automatically trigger upgrades when target_version is ahead of the current version #2034

Merged
merged 2 commits into from
Nov 14, 2024
Merged

feat(sns): Automatically trigger upgrades when target_version is ahead of the current version #2034

merged 2 commits into from
Nov 14, 2024

Conversation

anchpop
Copy link
Contributor

@anchpop anchpop commented Oct 15, 2024 •
edited
Loading

This PR adds a new periodic task (or rather, a new thing to be called from our existing periodic task) that will initiate an upgrade when one is necessary.

At the time of writing the proto backwards compatibility checker is complaining about this:

ic_sns_governance/pb/v1/governance.proto:1427:5:Field "4" with name "proposal_id" on message "PendingVersion" changed cardinality from "optional with implicit presence" to "optional with explicit presence".

Which I don't really think is a real issue, so I'm tagging the PR with CI_OVERRIDE_BUF_BREAKING

← Previous PR

@github-actions github-actions bot added the feat label Oct 15, 2024
@anchpop anchpop force-pushed the @anchpop/auto-upgrades branch 7 times, most recently from 09fa8df to 375daa6 Compare October 18, 2024 21:41
@anchpop anchpop force-pushed the @anchpop/auto-upgrades branch 4 times, most recently from d1511aa to 3c5f154 Compare October 31, 2024 22:07
@anchpop anchpop mentioned this pull request Oct 31, 2024
Merged
@anchpop anchpop force-pushed the @anchpop/auto-upgrades branch 2 times, most recently from a8bd052 to 4434107 Compare October 31, 2024 23:14
@aterga aterga changed the base branch from master to @anchpop/populate-upgrade-journal November 1, 2024 16:46
@anchpop anchpop force-pushed the @anchpop/populate-upgrade-journal branch 2 times, most recently from 6a0214d to b3c0b68 Compare November 1, 2024 23:42
@anchpop anchpop force-pushed the @anchpop/populate-upgrade-journal branch 2 times, most recently from d666e29 to e70bdf9 Compare November 4, 2024 17:08
github-merge-queue bot pushed a commit that referenced this pull request Nov 4, 2024
@anchpop
feat(sns): Populate upgrade journal (#2321)
cc80f84 
This PR populates the upgrade journal when new events occur. The upgrade
journal was first introduced in #2169

[← Previous PR](#2378) | [Next PR
→](#2034)
Base automatically changed from @anchpop/populate-upgrade-journal to master November 4, 2024 20:12
@anchpop anchpop force-pushed the @anchpop/auto-upgrades branch 4 times, most recently from 237faf2 to 09d1edd Compare November 5, 2024 16:35
@anchpop anchpop changed the title feat(sns): Try coming up with way to automatically trigger upgrades feat(sns): Automatically trigger upgrades when target_version is ahead of the current version Nov 5, 2024
@anchpop anchpop force-pushed the @anchpop/auto-upgrades branch 3 times, most recently from 97bfaff to 4dc102d Compare November 8, 2024 03:09
@anchpop anchpop added the CI_OVERRIDE_BUF_BREAKING Skip buf-breaking (protobuf) check (explain in PR description why) label Nov 8, 2024
@anchpop anchpop mentioned this pull request Nov 9, 2024
Merged
@anchpop anchpop force-pushed the @anchpop/auto-upgrades branch 2 times, most recently from f12e4bc to 0edfa11 Compare November 9, 2024 00:28
@anchpop anchpop force-pushed the @anchpop/auto-upgrades branch 2 times, most recently from 670c8a2 to 428d05c Compare November 12, 2024 21:55
github-merge-queue bot pushed a commit that referenced this pull request Nov 13, 2024
@anchpop
refactor(sns): Add helpers for the upgrade journal (#2527)
140a46b 
The upgrade journal event types were very verbose to construct
previously. This PR hopes to make them a litlte nicer

Addresses this:
#2034 (comment)
@anchpop anchpop force-pushed the @anchpop/auto-upgrades branch 3 times, most recently from 693f2e9 to 5f7f0aa Compare November 13, 2024 15:56
aterga
aterga approved these changes Nov 13, 2024
View reviewed changes
rs/nervous_system/common/src/lib.rs Outdated Show resolved Hide resolved
@anchpop anchpop force-pushed the @anchpop/auto-upgrades branch 4 times, most recently from b4772e7 to 5ea4c9e Compare November 14, 2024 01:43
andrew-lee-work
andrew-lee-work approved these changes Nov 14, 2024
View reviewed changes
Copy link
Contributor

@andrew-lee-work andrew-lee-work left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, other than the other comments I left.

rs/sns/governance/src/governance.rs Show resolved Hide resolved
rs/sns/governance/src/governance.rs Show resolved Hide resolved
@anchpop anchpop added this pull request to the merge queue Nov 14, 2024
Merged via the queue into master with commit 3c22b95 Nov 14, 2024
24 checks passed
@anchpop anchpop deleted the @anchpop/auto-upgrades branch November 14, 2024 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@max-dfinity max-dfinity max-dfinity left review comments

@andrew-lee-work andrew-lee-work andrew-lee-work approved these changes

@aterga aterga aterga approved these changes

Assignees
No one assigned
Labels
@boundary-node CI_OVERRIDE_BUF_BREAKING Skip buf-breaking (protobuf) check (explain in PR description why) @consensus @cross-chain-team @crypto-team @dre feat @ic-message-routing-owners @idx @networking @nns-team @pocket-ic
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@anchpop @aterga @andrew-lee-work @max-dfinity @dsarlis