chore(IDX): sync from gitlab #200
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chore(sns): Remove useless `restore_dapp_controllers` function [override-didc-check] I noticed this while hacking on swap and it confused me. The function only does anything if called by NNS Governance, and NNS governance doesn't call it. I think it's a holdover from 2-prop. Since we are removing a canister endpoint, this triggers the didc check, but since the endpoint didn't do anything for anyone who could have been calling it, I think this is fine. See merge request dfinity-lab/public/ic!19705
fix: [EXC-1643] count sign_with_schnorr contexts per key This MR fixes counting `sign_with_schnorr` call contexts per `key_id`. See merge request dfinity-lab/public/ic!19714
chore(CON-1257): Remove unused ecdsa code This MR removes some ECDSA code, that is no longer used and its corresponding test code. See merge request dfinity-lab/public/ic!19692
… 'master' chore(github-sync): PR#197 / chore(IDX): pigz: 2.7 -> 2.8 [GitHub PR 197](#197) (branch: basvandijk/upgrade-pigz-2.8-2nd-attempt) See merge request dfinity-lab/public/ic!19721
chore(github-sync): PR#198 / feat(CI): PR title cov workflow [GitHub PR 198](#198) (branch: marko-conv-commit-action) See merge request dfinity-lab/public/ic!19723
…equest contexts
feat(schnorr): CON-1262 EXC-1598 Match tSchnorr pre-signatures with request contexts Threshold signature requests need to be paired with a pre-signature for the requested key, and a random nonce, before we can start creating signature shares. The random nonce is assigned to the context in the round immediately subsequent to the round in which the request was matched with a pre-signature. Currently, this is only done for `SignWithEcdsaContext`s. Threshold Schnorr requests (and in the future also ECDSA) instead generate `SignWithThresholdContext`s which should also be matched with pre-signatures of the correct `MasterPublicKeyId`. In order to avoid code duplication, we map both request types to a `SignatureRequestContext` enum, which generalizes over mutable references to the individual contexts. Once we use the same context type for all signature requests, this may be removed again. We extend some unit tests to run for both signature schemes. See merge request dfinity-lab/public/ic!19697
chore(crypto): CRP-2504 Reject non-canonical Ed25519 point encodings in IDKG Honest peers should never produce such a point encoding. See merge request dfinity-lab/public/ic!19520
test(consensus): [CON-1298] Create integration test for subnet with stalled clocks This MR bundles the following changes: - Add an integration test that checks we make progress, despite having f malicious nodes *and* stalled clocks. - Add `stall_clocks` option to `ConsensusRunnerConfig` - Stops progressing relative time of all consensus instances - Can be set via environment variable - Introduce a `set_time_monotonic` helper function - Change `idle_since` from relative time to monotonic time See merge request dfinity-lab/public/ic!19267
feat(schnorr): CON-1262 Switch signer to new generalized signature requests contexts Currently, ECDSA signature requests still generate a `SignWithEcdsaContext`. Once we deploy a Schnorr key, Schnorr requests weill generate a generalized `SignWithThresholdContext` which will eventually also be used for ECDSA. In order to avoid having to handle both types of contexts separately, we create a function in the replicated state, mapping existing `SignWithEcdsaContext`s to `SignWithThresholdContext`s and returning them together with existing `SignWithThresholdContext`s. This allows us to handle both request types using the same interface. The remaining changes adapt names and types, and prepare for the addition of the tSchnorr implementation which remains unimplemented for now. This includes generation & validation of Schnorr signature shares, and creation & validation of combined Schnorr signatures. See merge request dfinity-lab/public/ic!19576
…aster' fix: Fix `Request` and `Payload` debug formatting `Request` would not print "Request" at the top or the `deadline` field. Both used fixed formatting (i.e. no support for pretty printing). And neither guarded against silently ignoring newly added fields. Also switched from truncation to ellipsizing in a couple of places. See merge request dfinity-lab/public/ic!19730
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.