Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(IDX): correct spelling error in bazel/workspace_status.sh #1714

Merged
merged 2 commits into from
Sep 27, 2024
Merged

fix(IDX): correct spelling error in bazel/workspace_status.sh #1714

merged 2 commits into from
Sep 27, 2024

Conversation

basvandijk
Copy link
Collaborator

No description provided.

@github-actions github-actions bot added the fix label Sep 27, 2024
@basvandijk basvandijk marked this pull request as ready for review September 27, 2024 09:15
@basvandijk basvandijk requested a review from a team as a code owner September 27, 2024 09:15
@github-actions github-actions bot added the @idx label Sep 27, 2024
nmattia
nmattia approved these changes Sep 27, 2024
View reviewed changes
Copy link
Contributor

@nmattia nmattia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was "$HOME/.bazel-volatile-status.txt" actually used then or can we remove it?

@basvandijk
Copy link
Collaborator Author

I don't think so, so we could potentially remove it.

@basvandijk basvandijk added this pull request to the merge queue Sep 27, 2024
@nmattia
Copy link
Contributor

nmattia commented Sep 27, 2024

we could potentially remove it.

Great! let's do it then

Merged via the queue into master with commit 687d84b Sep 27, 2024
26 checks passed
@basvandijk basvandijk deleted the basvandijk/fix-bazel-volatile-status.txt branch September 27, 2024 10:22
levifeldman pushed a commit to levifeldman/ic that referenced this pull request Oct 1, 2024
@basvandijk @levifeldman
fix(IDX): correct spelling error in bazel/workspace_status.sh (dfinit…
d9fcc17 
…y#1714)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nmattia nmattia nmattia approved these changes

Assignees
No one assigned
Labels
fix @idx
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@basvandijk @nmattia