feat(IDX): allow tests to depend on mainnet pocket-ic #1707
Conversation
This adds a build setting & related transition that allows for the pocket-ic version of tests to be overriden. By default `//:pocket-ic-server` points to the pocket-ic server from the source tree. This can be overriden by using `pocket_ic_mainnet_test` or by using the `//:pocket-ic-mainnet` target.
nmattia
force-pushed
the
nm-mainnet-pocket-ic
branch
from
838a9dd
to
d2e990e
Compare
| @@ -72,3 +73,8 @@ rust_ic_test( | |||
| "@crate_index//:candid", | |||
| ], | |||
| ) | |||
|
|
|||
| pocket_ic_mainnet_test( | |||
There was a problem hiding this comment.
this is just an example, not sure if meaningful or not
| # default pocket-ic variant/version (head) is the one as in the | ||
| # source tree. | ||
| string_setting( | ||
| name = "pocket-ic-variant", |
There was a problem hiding this comment.
How about being explicit about which pocket-ic "thing" we're mentioning here? pocket-ic usually refers to the library while the following is about the server:
| name = "pocket-ic-variant", | |
| name = "pocket-ic-server-variant", |
Same comment for the other things below.
There was a problem hiding this comment.
yep that makes sense!
| http_file( | ||
| name = "pocket-ic-mainnet-gz", | ||
| sha256 = "454891cac2421f3f894759ec5e6b6e48fbb544d79197bc29b88d34b93d78a4f1", | ||
| url = "https://download.dfinity.systems/ic/52ebccfba8855e23dcad9657a8d6e6be01df71f9/binaries/x86_64-linux/pocket-ic.gz", |
There was a problem hiding this comment.
I see mainnet is using c66489953ed34670667ad81ce42a172948f289f5.
Will you address syncing this with testnet/mainnet_revisions.json#L3 in another PR?
There was a problem hiding this comment.
Will you address syncing this with testnet/mainnet_revisions.json#L3 in another PR?
Yep, talked to DRE team and we'll be taking over the update of that file too. Let's sync offline
This adds a build setting & related transition that allows for the pocket-ic version of tests to be overriden. By default
//:pocket-ic-serverpoints to the pocket-ic server from the source tree. This can be overriden by usingpocket_ic_mainnet_testor by using the//:pocket-ic-mainnettarget.