feat: Increase install_code limit for application subnets #1705
+18
−52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsarlis
commented
Sep 26, 2024
There was a problem hiding this comment.
There are a bunch of changes in tests because a slightly bigger amount of cycles needs to be given to canisters to cover for the worst case install_code execution. Perhaps, an improvement can be made by having some sort of constant but I felt it's maybe easier to just fix them as such changes are expected to happen quite infrequently.
dragoljub-duric
approved these changes
Sep 26, 2024
Any commits made after this event will not be merged.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR increases the
install_codemessage limit for application subnets from 200B to 300B. This setting matches the one for verified application subnets and brings the gap closer between the two types.