refactor(IDX): update CI env vars #1703
Open
+29
−39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marko-k0
reviewed
Sep 26, 2024
.github/workflows-source/ci-main.yml
Outdated
| mkdir -p "/cache/job/${CI_JOB_ID}/${ROOT_PIPELINE_ID}/artifacts" | ||
| ln -s "/cache/job/${CI_JOB_ID}/${ROOT_PIPELINE_ID}/artifacts" /__w/$REPO_NAME/$REPO_NAME/artifacts | ||
| buildevents cmd "$ROOT_PIPELINE_ID" "$CI_JOB_ID" build-command -- \ | ||
| rm -rf "/cache/job/${CI_JOB_NAME}/${ROOT_PIPELINE_ID}" |
There was a problem hiding this comment.
We should use github.run_id. What we have now is actually not safe and we're prone to issues if two jobs are in the same machine and overlap.
There was a problem hiding this comment.
We already use that for ROOT_PIPELINE_ID
ic/.github/workflows-source/ci-main.yml
Line 30 in a95f743
CI_JOB_ID with ROOT_PIPELINE_ID here?
There was a problem hiding this comment.
Yes. We can do that. Probably as well rename ROOT_PIPELINE_ID.
cgundy
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Github Actions does not expose job_id, so we were using job_id and job_name interchangeably. To simplify, we replace
CI_JOB_IDwith what was previouslyROOT_PIPELINE_IDand removeROOT_PIPELINE_ID.