Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(EXC): Name Section for Metadata Command #69

Merged
merged 1 commit into from
Sep 5, 2024

Conversation

adambratschikaye
Copy link
Contributor

Add support for keeping the name section in the Wasm module when running the metadata command. Currently that command will always drop the name section when mutating the custom sections.

Add support for keeping the name section in the Wasm module when running
the `metadata` command. Currently that command will always drop the name
section when mutating the custom sections.
@adambratschikaye adambratschikaye requested a review from a team as a code owner September 4, 2024 13:19
@adambratschikaye
Copy link
Contributor Author

This is needed to enable including name sections for Rust canisters in the main repo where the metadata step is always run as determined by the bazel rules: https://github.com/dfinity/ic/blob/41c742d5de5e80ce0e812418c2cf5a87e04d37ac/bazel/canisters.bzl#L192-L193

@adambratschikaye adambratschikaye merged commit 085bbbf into main Sep 5, 2024
4 checks passed
@adambratschikaye adambratschikaye deleted the abk/metadata-cmd-name-section branch September 5, 2024 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants