feat: Add HTTP middleware for Transport replacement #598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ic-agent/src/agent/mod.rs
Outdated
| Box::pin(async move { | ||
| loop { | ||
| #[cfg(not(target_family = "wasm"))] | ||
| let resp = self.client.call(req, _max_retries).await?; |
There was a problem hiding this comment.
Maybe add max_retries for 429 instead of retrying indefinitely?
There was a problem hiding this comment.
The reason for retrying 429s indefinitely is because you are not served them indefinitely - even though it means the semaphore isn't doing its job, your message backlog will eventually be cleared, or if it grows too much, then you'll start getting message expiry timeouts. Is this bad logic?
lwshang
approved these changes
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ic-gateway was broken by #586, this provides a middle ground for them.