feat: replica-signed queries #480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericswanson-dfinity
approved these changes
Oct 5, 2023
|
Not to be merged, pending review by @roelstorms / @robin-kunzler. |
roelstorms
reviewed
Oct 11, 2023
roelstorms
reviewed
Oct 11, 2023
roelstorms
reviewed
Oct 17, 2023
roelstorms
reviewed
Oct 17, 2023
ShuoWangNSL
reviewed
Oct 17, 2023
ShuoWangNSL
reviewed
Oct 18, 2023
ShuoWangNSL
reviewed
Oct 30, 2023
ShuoWangNSL
reviewed
Nov 6, 2023
ShuoWangNSL
reviewed
Nov 7, 2023
since that makes testing impossible
ericswanson-dfinity
approved these changes
Nov 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements support for the node signatures provided in query calls by looking up the subnet node keys in the state tree. This provides resilience against rogue boundary nodes; clients will know whether the response came from the canister's subnet.
Implements SDK-1213 and SDK-1215.