Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(FI-913): add more icrc2_approve tests #150

Merged
merged 13 commits into from
Sep 4, 2023
Merged

feat(FI-913): add more icrc2_approve tests #150

merged 13 commits into from
Sep 4, 2023

Conversation

maciejdfinity
Copy link
Contributor

@maciejdfinity maciejdfinity commented Aug 28, 2023 •
edited
Loading

Extended the basic test for icrc2_approve and added tests for approval expiration and expected allowance.

@maciejdfinity maciejdfinity changed the title Add icrc2_approve tests feat(FI-913): add more icrc2_approve tests Aug 28, 2023
NikolasHai
NikolasHai reviewed Aug 28, 2023
View reviewed changes
test/suite/lib.rs Outdated Show resolved Hide resolved
test/suite/lib.rs Show resolved Hide resolved
test/suite/lib.rs Outdated Show resolved Hide resolved
test/suite/lib.rs Outdated Show resolved Hide resolved
test/suite/lib.rs Outdated Show resolved Hide resolved
test/suite/lib.rs Outdated Show resolved Hide resolved
test/suite/lib.rs Outdated Show resolved Hide resolved
@maciejdfinity maciejdfinity merged commit 36a45a5 into main Sep 4, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NikolasHai NikolasHai NikolasHai left review comments

@MarioDfinity MarioDfinity MarioDfinity approved these changes

@roman-kashitsyn roman-kashitsyn Awaiting requested review from roman-kashitsyn

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maciejdfinity @MarioDfinity @NikolasHai