Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XM-2631 Fix AU Pay Template #2

Merged
merged 1 commit into from
Feb 1, 2022
Merged

Conversation

alys-dext
Copy link

@alys-dext alys-dext commented Jan 31, 2022

See calcinai#841

In summary, we need the PayTemplate.LeaveLines.EntitlementFinalPayPayoutType value from the Employees table in MongoDB, in order to complete XM-2384. The issue we came across was that LeaveLines was only ever an empty array for AU.

This work resolves this issue, and LeaveLines (and SuperLines) now returns an array of expected values.

Before:

image

After:

Screenshot 2022-01-31 at 11 35 31

Testing

To require feature branch:

devenv composer require calcinai/xero-php:dev-XM-2384-fix-AU-pay-template

To populate Employees table:

  • Set Team (must be a dext team) location to AU (teams.location in DB)
  • Create & import AU Demo Company from Xero
  • Enable payroll feature flag (payroll-au)
  • Enable 2FA for user (users.uses_two_factor_auth in DB)
  • Navigate to Client > Insights > Payroll to enable Payroll for client
  • Sync client & you should now see data in the employees table in Mongo :slight_smile:

Copy link

@oliversiket oliversiket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

Copy link

@daniel-rees-rb daniel-rees-rb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@alys-dext alys-dext changed the title XM-2384 Fix AU Pay Template XM-2631 Fix AU Pay Template Feb 1, 2022
@nickayre1 nickayre1 merged commit ab04f17 into develop Feb 1, 2022
@nickayre1 nickayre1 deleted the XM-2384-fix-AU-pay-template branch February 1, 2022 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants