add docs for generic oauth 2.0 connector #91
Conversation
Signed-off-by: Rui Yang <[email protected]>
content/docs/connectors/oauth.md
Outdated
| date: 2021-03-15 | ||
| draft: false | ||
| toc: true | ||
| weight: 2050 |
There was a problem hiding this comment.
This is the same weight as oidc -- which means it will be next to it in the menus. Is this a good position for this page?
There was a problem hiding this comment.
thx for pointing that out! Didn't think about this value as i took it from OIDC doc directly.
How is the weight being decided (relevance/importance/users number/time being added)? Though, this connector is indeed close to OIDC connector since OIDC is just a layer on top of oauth 2.0 protocol.
There was a problem hiding this comment.
Maybe we slot it in above OIDC then, thoughts @sagikazarmark?
| weight: 2050 | |
| weight: 2045 |
There was a problem hiding this comment.
Sorry for interfering. I thought connectors should be in the order they appear in the table on the index page. If you want it to be above OIDC, you need to change its order in the table as well.
There was a problem hiding this comment.
Personally, I'd like to see this list sorted by importance (arbitrary) and alphabetical. Eg.:
- OIDC
- OAuth 2.0
- SAML
- LDAP
- Provider specific connectors in alphabetical order
So I guess for now it's fine under OIDC.
There was a problem hiding this comment.
Set it to 2055 so it goes under OIDC. Also positioned it under OIDC in the connectors table.
|
@xtremerui thanks for this! I've made a couple notes on the copy, and have invited @sagikazarmark to do the technical review. |
Signed-off-by: Rui Yang <[email protected]>
|
@nate-double-u thank you! Appreciate your help. |
content/docs/connectors/oauth.md
Outdated
| linkTitle: "Generic OAuth 2.0" | ||
| description: "" | ||
| date: 2021-03-15 | ||
| draft: false |
There was a problem hiding this comment.
I think we should make it a draft and merge it to master. Once the feature is released, we can flip the switch.
There was a problem hiding this comment.
This would also be a great opportunity to figure #92 out. @nate-double-u do you think you can help us out with that?
There was a problem hiding this comment.
I'd be happy to take a look.
[edit] #93
There was a problem hiding this comment.
I think we should make it a draft and merge it to master. Once the feature is released, we can flip the switch.
Have to be careful with that -- this PR touches a couple files
Signed-off-by: Rui Yang <[email protected]>
|
@sagikazarmark just wondering do you still need this one since the PR for generic oauth 2 connector is already merged and released? |
this is the doc for generic oauth 2.0 connector that PR in dexidp/dex#1630