Added Discovery to grpc #3598
Merged
Added Discovery to grpc #3598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koendelaat
force-pushed
the
feature/grpc-discovery
branch
from
8d0ac8b
to
2be966f
Compare
Signed-off-by: Koen de Laat <[email protected]>
koendelaat
force-pushed
the
feature/grpc-discovery
branch
from
2be966f
to
6bbd1ff
Compare
|
@nabokihms, Can you add the required labels? |
koendelaat
force-pushed
the
feature/grpc-discovery
branch
from
cf4ec26
to
6bbd1ff
Compare
|
@koendelaat sure I can! Could you please share why do we need this feature? |
This allows for API clients to get information about the Dex server. Especially when used in Infrastructure as Code (e.g. Terraform, Crossplane), this information can be used to provision other resources that might require this information (e.g. I've extended the terraform provider with this functionality based on this PR, see https://github.com/koendelaat/terraform-provider-dexidp/ and https://registry.terraform.io/providers/koendelaat/dexidp/latest/docs/data-sources/discovery |
nabokihms
approved these changes
Aug 29, 2024
koendelaat
added a commit
to koendelaat/terraform-provider-dexidp
that referenced
this pull request
Sep 11, 2024
Signed-off-by: Koen de Laat <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Adds the discovery information to the API
What this PR does / why we need it
Allow API clients to retrieve important information regarding dex config (e.g.
issuerUrl)Use-case:
API is being used to create
clients, however to use this client theissuerUrlis required