Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: vulnerability exposure tab #2064

Merged
merged 21 commits into from
Oct 1, 2024
Merged

refactor: vulnerability exposure tab #2064

merged 21 commits into from
Oct 1, 2024

Conversation

arunjaindev
Copy link
Contributor

Description

use url filters hook
use filter chips
use filter select picker
revamp ui design

Screenshot 2024-09-18 at 6 12 27 PM

Fixes https://github.com/devtron-labs/sprint-tasks/issues/897

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas

@arunjaindev arunjaindev changed the base branch from main to feat/security-summary-card September 18, 2024 12:43
AbhishekA1509
AbhishekA1509 requested changes Sep 19, 2024
View reviewed changes
src/components/security/VulnerabilityExposure.tsx Outdated Show resolved Hide resolved
src/components/security/security.util.tsx Outdated Show resolved Hide resolved
src/components/security/VulnerabilityExposure.tsx Outdated Show resolved Hide resolved
src/components/security/VulnerabilityExposure.tsx Outdated Show resolved Hide resolved
src/components/security/security.service.ts Show resolved Hide resolved
AbhishekA1509
AbhishekA1509 previously approved these changes Sep 19, 2024
View reviewed changes
vivek-devtron
vivek-devtron previously approved these changes Sep 19, 2024
View reviewed changes
Base automatically changed from feat/security-summary-card to develop September 24, 2024 08:07
@arunjaindev arunjaindev dismissed stale reviews from vivek-devtron and AbhishekA1509 September 24, 2024 08:07

The base branch was changed.

@arunjaindev
Merge branch 'develop' of https://github.com/devtron-labs/dashboard i…
41b5885 
…nto fix/force-delete-helm
@arunjaindev
Merge branch 'develop' of https://github.com/devtron-labs/dashboard i…
05a650d 
…nto refactor/vulnerability-exposure
@arunjaindev
Merge branch 'refactor/vulnerability-exposure' of https://github.com/…
22fcf1b 
…devtron-labs/dashboard into fix/force-delete-helm
@arunjaindev
chore: version bump
e7f2c07
@arunjaindev
Merge branch 'develop' of https://github.com/devtron-labs/dashboard i…
99bcb50 
…nto fix/force-delete-helm
@arunjaindev
fix: deployment app type is always set as helm in chart values view
d8e096b
@arunjaindev
Merge branch 'develop' of https://github.com/devtron-labs/dashboard i…
f704d03 
…nto refactor/vulnerability-exposure
@arunjaindev
Merge branch 'refactor/vulnerability-exposure' of https://github.com/…
b7a9660 
…devtron-labs/dashboard into fix/force-delete-helm
@arunjaindev
Merge pull request #2049 from devtron-labs/fix/force-delete-helm
4c667e2 
fix: force delete when cluster unreachable
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 1, 2024

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@arunjaindev arunjaindev merged commit d6ef9d7 into develop Oct 1, 2024
4 of 5 checks passed
@arunjaindev arunjaindev deleted the refactor/vulnerability-exposure branch October 1, 2024 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vivek-devtron vivek-devtron vivek-devtron approved these changes

@AbhishekA1509 AbhishekA1509 AbhishekA1509 left review comments

@vikramdevtron vikramdevtron Awaiting requested review from vikramdevtron vikramdevtron is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@arunjaindev @vivek-devtron @AbhishekA1509