A couple of debugging experience fixes #11
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MohamedBassem
force-pushed
the
pr11
branch
2 times, most recently
from
2008af6
to
552a428
Compare
AhmedSoliman
requested changes
Jul 25, 2023
1. Allow passing --project-id to any subcommand instead of only admin commands. 2. A stricter secret api key matching using regex. Only matching with the prefix was too aggressive matching stuff like "_task_something". 3. Add IP addresses to request tracing
AhmedSoliman
approved these changes
Jul 25, 2023
|
Merged in #12 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A couple of debugging experience fixes
Stack created with Sapling. Best reviewed with ReviewStack.