Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support domain layer #131

Open
hohwille opened this issue Aug 10, 2021 · 0 comments
Open

Support domain layer #131

hohwille opened this issue Aug 10, 2021 · 0 comments

Comments

@hohwille
Copy link
Member

hohwille commented Aug 10, 2021

Currently the layer for connecting with database is called dataaccess.
This is compliant with the classic project structure.
However, with the modern project structure the layer has been renamed to domain.

This story is about changing this sonar-devon4j-plugin so that domain is accepted as synonym to dataaccess. If we already change this, we should also accept persistence as a synonym as well that is used by RegisterFactory / IsyFact.
This is already archivable via custom configuration in architecture.json but should be supported out of the box with the default config.
See also https://github.com/devonfw/sonar-devon4j-plugin/blob/master/src/main/java/com/devonfw/ide/sonarqube/common/api/config/DevonPackageImpl.java

A JUnit test has to be part of this story that tests multiple Java packages with default configuration (new Configuration()) via DevonPackageImpl. It should test the three layers valid for dataaccess/domain layer as well as a the other valid layers (service, logic, common) and also an invalid layer (e.g. with typo such as domian) and assert proper expected results.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants