Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to finish devonfw-ide installation #77

Open
jambulud opened this issue Sep 28, 2020 · 1 comment
Open

Unable to finish devonfw-ide installation #77

jambulud opened this issue Sep 28, 2020 · 1 comment
Labels
bug Something isn't working

Comments

@jambulud
Copy link
Member

jambulud commented Sep 28, 2020

Describe the bug
When the installation of a new devonfw-ide version finishes, the cancel button does not change to finished

To Reproduce
Steps to reproduce the behavior:

  1. Go to devonfw dashboard folder
  2. Open a terminal an start devonfw dashboard.
  3. Click on install latest version
  4. Complete the installation process with default data
  5. See in the installation terminal the message Completed, but the button is still on Cancel

Expected behavior
When the installation terminal displays Completed, the button Cancel should transform to Close.

Desktop (please complete the following information):

  • OS: Linux

Additional context
In Windows, when the terminal shows Press any key to continue, it sends a finished status to the front-end side. If this message is omitted in linux, then it won't send finished

@jambulud jambulud added the bug Something isn't working label Sep 28, 2020
@suprishi
Copy link
Member

So should there be an issue raised in ide for adding a terminating message in linux/mac on successful installation or should it be handled in dashboard only?

Also, for Windows, is this the best way to determine finished status since it is tightly coupled with the terminating message? If for whatsoever reasons the message is changed or discarded in the future, it would have to be handled in the dashboard.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants