Avoid non-Git constants conflict, update root comment #415
+14
−10
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As presently defined, if a custom constant in user's project had a naming conflict (i.e.
Root
orUrl
), the item metadata in the editorconfig/options would be mixed up, since it uses the item spec for that.By using the full area name, we avoid that, and switch instead to the custom root feature of using
Root=.
instead.We also take advantage of the new custom root summary comment to better reflect the nature of the provided constants.