Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with ARM7 define in GBA cmake and libfat #348

Closed
Lorenzooone opened this issue Mar 18, 2024 · 2 comments
Closed

Issue with ARM7 define in GBA cmake and libfat #348

Lorenzooone opened this issue Mar 18, 2024 · 2 comments

Comments

@Lorenzooone
Copy link

Here the cmake defines ARM7 for the GBA cmake:

set(GBA_COMMON_FLAGS "-ffunction-sections -fdata-sections -D__GBA__ -DARM7")

However, libfat checks for ARM7 to define NDS in its header, which then causes issues when its tries to include ds-specific files here:
https://github.com/devkitPro/libfat/blob/154f7829d43421754085877d533d66743d42619a/include/fat.h#L43

@Lorenzooone Lorenzooone changed the title Issue with ARM7 define in GBA cmake and LibFAT Issue with ARM7 define in GBA cmake and libfat Mar 18, 2024
@endrift
Copy link

endrift commented Mar 20, 2024

I filed devkitPro/libfat#25 to take care of it in libfat instead of the cmake toolchains.

@Lorenzooone
Copy link
Author

Okay, sounds good.
I was kind of worried that this define could have problematic interactions with other libraries as well. But if that is not the case, changing libfat only should suffice.

Closing the issue for now. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants