TMS-1044: Accordion-block open all / close all functionality #511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vloy
reviewed
May 31, 2024
assets/scripts/accordion.js
Outdated
| /** | ||
| * Opens all dropdowns. | ||
| * | ||
| * @param {HTMLButtonElement} mainContainer Main container for accordion dropdowns. |
There was a problem hiding this comment.
Suggested change
| * @param {HTMLButtonElement} mainContainer Main container for accordion dropdowns. | |
| * @param {HTMLDivElement} mainContainer Main container for accordion dropdowns. |
?
vloy
reviewed
May 31, 2024
assets/scripts/accordion.js
Outdated
| /** | ||
| * Closes all dropdowns. | ||
| * | ||
| * @param {HTMLButtonElement} mainContainer Main container for accordion dropdowns. |
There was a problem hiding this comment.
Suggested change
| * @param {HTMLButtonElement} mainContainer Main container for accordion dropdowns. | |
| * @param {HTMLDivElement} mainContainer Main container for accordion dropdowns. |
vloy
reviewed
May 31, 2024
assets/scripts/accordion.js
Outdated
| /** | ||
| * Updates "Close all" or "Open all" -button states depending on open accordion dropdowns. | ||
| * | ||
| * @param {HTMLButtonElement} mainContainer Main container for accordion dropdowns. |
There was a problem hiding this comment.
Suggested change
| * @param {HTMLButtonElement} mainContainer Main container for accordion dropdowns. | |
| * @param {HTMLDivElement} mainContainer Main container for accordion dropdowns. |
vloy
reviewed
May 31, 2024
Comment on lines
+4
to
+16
| color: $primary !important; | ||
| background-color: transparent !important; | ||
| border: none !important; | ||
| border-radius: 0 !important; | ||
|
|
||
| .icon { | ||
| margin-left: $theme-spacing-three-quarters !important; | ||
| } | ||
|
|
||
| &:hover { | ||
| filter: none !important; | ||
| box-shadow: none !important; | ||
| text-decoration: underline !important; |
There was a problem hiding this comment.
Voisi kommentoida, miksi käytetty !important.
Yliajetaanko esim. bulman tyylejä?
vloy
reviewed
May 31, 2024
Comment on lines
57
to
60
| 'expand' => _x( 'Expand', 'theme-frontend', 'tms-theme-base' ), | ||
| 'collapse' => _x( 'Collapse', 'theme-frontend', 'tms-theme-base' ), | ||
| 'expand_all' => _x( 'Expand all sections', 'theme-frontend', 'tms-theme-base' ), | ||
| 'collapse_all' => _x( 'Collapse all sections', 'theme-frontend', 'tms-theme-base' ), |
There was a problem hiding this comment.
Suggested change
| 'expand' => _x( 'Expand', 'theme-frontend', 'tms-theme-base' ), | |
| 'collapse' => _x( 'Collapse', 'theme-frontend', 'tms-theme-base' ), | |
| 'expand_all' => _x( 'Expand all sections', 'theme-frontend', 'tms-theme-base' ), | |
| 'collapse_all' => _x( 'Collapse all sections', 'theme-frontend', 'tms-theme-base' ), | |
| 'expand' => \_x( 'Expand', 'theme-frontend', 'tms-theme-base' ), | |
| 'collapse' => \_x( 'Collapse', 'theme-frontend', 'tms-theme-base' ), | |
| 'expand_all' => \_x( 'Expand all sections', 'theme-frontend', 'tms-theme-base' ), | |
| 'collapse_all' => \_x( 'Collapse all sections', 'theme-frontend', 'tms-theme-base' ), |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Severa-ID: 2108
Severa-kuvaus: TMS-1044 Haitarilohkoon kehitystä
Task: https://hiondigital.atlassian.net/browse/TMS-1044
Description
Types of changes