TMS-1034: Add default text for articles related content title #508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HPiirainen
approved these changes
May 13, 2024
| @@ -158,7 +158,7 @@ public function related() : ?array { | |||
| ); | |||
|
|
|||
| return [ | |||
| 'title' => get_field( 'related_title' ) ?? '', | |||
| 'title' => get_field( 'related_title' ) ?? __( 'Related posts', 'tms-theme-base' ), | |||
There was a problem hiding this comment.
Tässä kannattaa muistaa, että jos get_field palauttaa esim. false tai tyhjän stringin, niin tuo fallback ei tule voimaan. Se asetetaan vain, jos get_field palauttaa nullin.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Severa-ID: 2247
Severa-kuvaus: TMS-1034 Drupalista tulevista uutisista puuttuu Liittyvät sisällöt -otsikko
Task: https://hiondigital.atlassian.net/browse/TMS-1034
Description
Add default text to related content -section if the field has no value
Motivation and Context
Articles have a "related_title" field, that has the same default-value as this added text, but for the imported news that field never updates its value, which is why this change is needed.
Types of changes