TMS-1010: Fix events-lift component sorting with recurring events #490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Liblastic
reviewed
Jan 25, 2024
| $events = array_slice( $events, 0, $layout['page_size'] ); | ||
| } | ||
| // Show selected amount of events | ||
| $events = array_slice( $events, 0, $layout['page_size'] ); |
There was a problem hiding this comment.
Mietin iha arkkitehtuurisesti et querytetaanko jotain turhaan kun nämä tehdään tässä kohdassa, mutta eiköhän tämä ole mietitty silloin kun on tehty. 🤔
Sitä voi tutkia jos tämä toiminto on esim. erityisen hidas.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Severa-ID: 2247
Severa-kuvaus: TMS-1010 Muumimuseon tapahtumanoston lukumääräasetus ei toimi
Task: https://hiondigital.atlassian.net/browse/TMS-1010
Description
Fix events-lift component sorting with recurring events
Types of changes