Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make test.sh better #29

Open
jcbhmr opened this issue May 10, 2023 · 2 comments
Open

Make test.sh better #29

jcbhmr opened this issue May 10, 2023 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@jcbhmr
Copy link
Member

jcbhmr commented May 10, 2023

problem: the test.sh is confusing
i.e. not everyone (me included) know what the heck happens in that magic bash script 🤣

this isn't a major problem, but it is a thing to do that i think is a good idea. 😉

solution 1: make it a python script instead with more friendly programming language syntax
solution 2: add a bunch of comments

i vote solution 1. i originally tried to do this in the #20 pr, but was too complicated at the time. time for another crack at it?

@jcbhmr jcbhmr added the enhancement New feature or request label May 10, 2023
@jcbhmr jcbhmr self-assigned this May 10, 2023
@jcbhmr

This comment was marked as off-topic.

@eitsupi
Copy link
Contributor

eitsupi commented May 10, 2023

I think that the content of this script is confusing, not because of the language, but because there is no way to check the intermediate file (the generated devcontainer.json).

My preference is to use Makefiles to split tasks so they can be executed in order.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants