Fixes SeIncreaseQuotaPrivilege #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: imjoseangel <[email protected]>
rndmh3ro
reviewed
Jun 27, 2020
| its('SeIncreaseQuotaPrivilege') { should include 'S-1-5-19' } | ||
| its('SeIncreaseQuotaPrivilege') { should include 'S-1-5-20' } | ||
| its('SeIncreaseQuotaPrivilege') { should include 'S-1-5-32-544' } | ||
| its('SeIncreaseQuotaPrivilege') { should eq ['S-1-5-19', 'S-1-5-20', 'S-1-5-32-544'] } |
There was a problem hiding this comment.
Does this still work, if it is not in this exact order?
There was a problem hiding this comment.
Hi @rndmh3ro ,
I have tested it and is about how Windows manages the list:
By default you have:
Administrators
LOCAL SERVICE
NETWORK SERVICE
If you remove Administrators group, you get:
× windows-014: Ensure 'Adjust memory quotas for a process' is set to 'Administrators, LOCAL SERVICE, NETWORK SERVICE'
× Security Policy SeIncreaseQuotaPrivilege is expected to eq ["S-1-5-19", "S-1-5-20", "S-1-5-32-544"]
expected: ["S-1-5-19", "S-1-5-20", "S-1-5-32-544"]
got: ["S-1-5-19", "S-1-5-20"]
(compared using ==)When adding back, Windows returns the list in that exact order always:
✔ windows-014: Ensure 'Adjust memory quotas for a process' is set to 'Administrators, LOCAL SERVICE, NETWORK SERVICE'
✔ Security Policy SeIncreaseQuotaPrivilege is expected to eq ["S-1-5-19", "S-1-5-20", "S-1-5-32-544"]If you add an extra user:
× windows-014: Ensure 'Adjust memory quotas for a process' is set to 'Administrators, LOCAL SERVICE, NETWORK SERVICE'
× Security Policy SeIncreaseQuotaPrivilege is expected to eq ["S-1-5-19", "S-1-5-20", "S-1-5-32-544"]
expected: ["S-1-5-19", "S-1-5-20", "S-1-5-32-544"]
got: ["S-1-5-19", "S-1-5-20", "imjoseangel", "S-1-5-32-544"]
(compared using ==)etc
There was a problem hiding this comment.
Thanks for investigating this!
|
LGTM! @chris-rock any remarks? |
chris-rock
approved these changes
Jun 30, 2020
|
Thank you @imjoseangel for this improvement! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: imjoseangel [email protected]
Fixes #20 and #22