-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2 Shulker instances in the same channel can's see each other #49
Comments
I've only just found Shulker today, so I haven't done any testing myself with multiple instances, but I've been messing around with Discord webhooks/bots and I know my way around JavaScript. When Shulker decides whether to forward messages to the Minecraft server, one of the checks it makes is this: Lines 56 to 57 in b174e69
Are you using the same Discord channel webhook for both instances, by any chance? |
That line is saying "if shulker is configured to use webhooks and the
message is made by any webhook, ignore it"
…On Sun, Apr 19, 2020, 8:14 AM Ben Landin ***@***.***> wrote:
I've only just found Shulker today, so I haven't done any testing myself
with multiple instances, but I've been messing around with Discord
webhooks/bots and I know my way around JavaScript.
When Shulker decides whether to forward messages to the Minecraft server,
one of the checks it makes is this:
https://github.com/destruc7i0n/shulker/blob/b174e696b2667990720b0b427eb9905a350c648f/src/Discord.ts#L56-L57
Are you using the same Discord channel webhook for both instances, by any
chance?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#49 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABYT6YVU7K4XZTHLQGBTHWTRNL2KBANCNFSM4L3KE72A>
.
|
Oh, whoops. Completely missed that it's checking for thruthiness and not comparing the value. You're right. |
I pushed an option for this here e288b74 |
I need to spin up my second server again, I shut it down when my server was lagging because of my uncle's 252 turtles:
I should be able to get to it this weekend or just after, my finals are wrapping up soon. |
I've got 2 instances of Shulker each running on different servers and I was hoping this would bridge their chats in addition to showing them on Discord, but it just makes it into a situation where you only hear one side of a telephone conversation. Is there a way to fix this?
The text was updated successfully, but these errors were encountered: