Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2 Shulker instances in the same channel can's see each other #49

Open
UndarkAido opened this issue Apr 3, 2020 · 5 comments
Open

2 Shulker instances in the same channel can's see each other #49

UndarkAido opened this issue Apr 3, 2020 · 5 comments

Comments

@UndarkAido
Copy link

image

I've got 2 instances of Shulker each running on different servers and I was hoping this would bridge their chats in addition to showing them on Discord, but it just makes it into a situation where you only hear one side of a telephone conversation. Is there a way to fix this?

@blandin
Copy link
Contributor

blandin commented Apr 19, 2020

I've only just found Shulker today, so I haven't done any testing myself with multiple instances, but I've been messing around with Discord webhooks/bots and I know my way around JavaScript.

When Shulker decides whether to forward messages to the Minecraft server, one of the checks it makes is this:

shulker/src/Discord.ts

Lines 56 to 57 in b174e69

// if using webhooks, ignore this!
if (this.config.USE_WEBHOOKS && message.webhookID) return

Are you using the same Discord channel webhook for both instances, by any chance?

@UndarkAido
Copy link
Author

UndarkAido commented Apr 19, 2020 via email

@blandin
Copy link
Contributor

blandin commented Apr 19, 2020

Oh, whoops. Completely missed that it's checking for thruthiness and not comparing the value. You're right.

@destruc7i0n
Copy link
Owner

destruc7i0n commented Apr 29, 2020

I pushed an option for this here e288b74

@UndarkAido
Copy link
Author

UndarkAido commented May 7, 2020

I need to spin up my second server again, I shut it down when my server was lagging because of my uncle's 252 turtles:

Version: 1.15.2
Time span: 9699 ms
Tick span: 138 ticks
// This is approximately 14.23 ticks per second. It should be 20 ticks per second
...
minecraft:turtle(34776/252) - 37.55%/31.94%

I should be able to get to it this weekend or just after, my finals are wrapping up soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants