Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove yarn add for playwright packages #1704

Merged
merged 1 commit into from
Oct 8, 2024

Conversation

anastasialanz
Copy link
Contributor

@anastasialanz anastasialanz commented Oct 8, 2024

We had this problem earlier where the playwright image updates and we get an error. When running yarn add, Docker wasn't getting the ARG playwright_version so we need to redeclare it after the first FROM.

An ARG declared before a FROM is outside of a build stage, so it can't be used in any instruction after a FROM. To use the default value of an ARG declared before the first FROM use an ARG instruction without a value inside of a build stage

https://docs.docker.com/reference/dockerfile/#understand-how-arg-and-from-interact

Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-1704.d15792l1n26ww3.amplifyapp.com

@anastasialanz anastasialanz force-pushed the fix--playwright-docker branch 2 times, most recently from b71a265 to 0035783 Compare October 8, 2024 18:16
@anastasialanz anastasialanz reopened this Oct 8, 2024
@anastasialanz anastasialanz marked this pull request as ready for review October 8, 2024 19:00
@anastasialanz anastasialanz requested a review from a team as a code owner October 8, 2024 19:00
@anastasialanz anastasialanz merged commit fbd45e8 into develop Oct 8, 2024
13 checks passed
@anastasialanz anastasialanz deleted the fix--playwright-docker branch October 8, 2024 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants