feat: adjust TagButton icon size and add position prop #1401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yhafez
commented
Mar 8, 2024
| margin-right: var(--space-quarter); | ||
| } | ||
|
|
||
| .TagButton .TagButton__icon svg { |
There was a problem hiding this comment.
This was being overridden by .Icon svg, so I increased its specificity
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
scurker
requested changes
Mar 12, 2024
There was a problem hiding this comment.
I think the only change that can land for sure right now is the icon size change.
Knowing what we know now, this is not likely how we would implement icon customization in this component - so that's a bit of a miss on our part. I think this is in a bit of a holding pattern and @shawnsharpDQ is aware but wanted to at least let you know we're still looking into what we actually need to do here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.